Ensure keywords exist for all sources#91
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds missing Keywords metadata for Ampere document sources in the embedding-generation source list, and introduces a validation test to prevent future CSV rows from being added without keywords (supporting lexical/BM25 retrieval quality).
Changes:
- Populate
Keywordsfor Ampere sources invector-db-sources.csv(and remove an invalidchrome-extension://URL form). - Add a pytest that asserts all rows with a non-empty URL also have non-empty
Keywords, and that required columns exist.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| embedding-generation/vector-db-sources.csv | Adds keyword values for Ampere sources so they participate in lexical retrieval and meet the new validation requirement. |
| embedding-generation/tests/test_vector_db_sources.py | Adds a CSV validation test enforcing presence of Keywords (and required columns) for all source rows. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
STESOL-520
Add keywords for Ampere sources and add test to ensure future sources always have keywords