You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks a lot for your patches @Nauscar . Two nitpicks on this one:
I think review_dir should treat relative paths as relative to --codebase-path. For example, if I run: metis --codebase-path /tmp/project --command "review_dir src"
I’d expect it to review /tmp/project/src, but with the current code it walks src relative to the current working directory.
review_dir should follow the same quiet/non-interactive behavior as review_code. Right now it always goes through the progress UI path, so --quiet / non-interactive output won’t be as clean as the other review commands
Appreciate the feedback @mpekatsoula. I believe I have resolved the two items with the latest commit. Please let me know if you prefer a different approach to the minor code refactoring I have done and I can take another pass.
Usage of os.path.join to concatenate dir_path and tested with uv run metis --quiet --codebase-path /workspaces/metis --non-interactive --command "review_dir <subdir>".
Created a shared function _review_code and added optional kwargs parameters to other supporting functions to support different code_files as input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this command useful when indexing an entire workspace in a large Rust codebase, and reviewing relevant crates (directories) one at a time.