Rrivera/subsystem common context tables#423
Open
rrivera747 wants to merge 7 commits into
Open
Conversation
…Subsystems in override or not modes
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends otsdaq’s “SubsystemCommon” mechanism to support Context-group common tables (and overrides) that can be propagated from a top-level Gateway to remote subsystems via periodic status requests, enabling dynamic updates of Context tables (e.g., StateMachineTable) on remote gateways. It also improves diagnostic error messages and tightens table-merge behavior.
Changes:
- Add new version-alias types
SubsystemCommonContext/SubsystemCommonContextOverride, validate they only reference Context-group tables, and implementConfigurationManager::applyContextCommonTables()to apply them to active tables. - Extend Gateway-to-Gateway UDP status messaging to include pipe-delimited encoded Context Common table lists, parse/apply them on the remote side, and surface lists in status XML.
- Improve merge/apply correctness (e.g.,
mergeViews()tracks appended rows) and enhance runtime error messages for table operations.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| otsdaq/TableCore/TableView.cc | Improves exception messages with table/version/row/col context for easier debugging. |
| otsdaq/TableCore/TableBase.cc | Fixes mergeViews() bookkeeping by updating destSize when rows are appended. |
| otsdaq/GatewaySupervisor/GatewaySupervisor.h | Adds new command preambles and member state/mutex for Context Common table propagation. |
| otsdaq/GatewaySupervisor/GatewaySupervisor.cc | Implements Context Common table list caching, transport over status requests, remote parsing, and application to active Context tables. |
| otsdaq/ConfigurationInterface/ConfigurationTree.cc | Adjusts debug logging verbosity for bitmap parsing. |
| otsdaq/ConfigurationInterface/ConfigurationManager.h | Declares new alias constants and applyContextCommonTables() API. |
| otsdaq/ConfigurationInterface/ConfigurationManager.cc | Defines new alias constants, validates Context-only alias usage, and implements Context Common apply logic via mergeViews(). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.