fix: add windows-native keyring feature for credential persistence on Windows - #90
Open
lihaooo wants to merge 1 commit into
Open
Conversation
… on Windows The keyring v3 crate has no default features. Without `windows-native`, there is no credential store backend on Windows. `set_password()` silently returns Ok without persisting, causing `ak auth whoami` to fail after login. Fixes artifact-keeper#89
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
windows-nativefeature to thekeyringcrate so that Windows Credential Manager is used as the native backend for storing login credentials.Fixes #89
Background
The
keyringv3 crate has no default features. Onlyapple-nativeandlinux-nativewere enabled, leaving Windows without any credential store backend.set_password()silently returnedOkwithout persisting, causingak auth whoamito fail after a successfulak auth login.Test plan
cargo build --releasesucceeds on Windowscargo test --workspace— 1409 tests passak auth login→ak auth whoamiroundtrip works on Windows 11