fix : add dark-mode theming and remove emojis from OnboardingModal#1908
Open
tmdeveloper007 wants to merge 2 commits into
Open
fix : add dark-mode theming and remove emojis from OnboardingModal#1908tmdeveloper007 wants to merge 2 commits into
tmdeveloper007 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of What Has Been Done
Replaced all hardcoded dark-mode hex colors in OnboardingModal with Tailwind dark mode variants. Replaced all emoji characters with Lucide React icon components. Added comprehensive ARIA accessibility attributes.
Changes Made
bg-[#141f2b]withbg-white dark:bg-slate-900text-[#e2eaf2]withtext-slate-900 dark:text-slate-100text-[#7a9bb5]withtext-slate-500 dark:text-slate-400text-[#c5d8e8]withtext-slate-800 dark:text-slate-200text-[#5a7a92]withtext-slate-400 dark:text-slate-500border-[#1e3a4a]withborder-slate-200 dark:border-slate-700bg-[#0f1923]withbg-slate-50 dark:bg-slate-800bg-[#1e2e3d]withbg-slate-100 dark:bg-slate-800border-[#1e2e3d]withborder-slate-200 dark:border-slate-700border-[#1e3a4a]withborder-slate-200 dark:border-slate-700aria-label="Skip onboarding tour"to skip buttonaria-label="Go to previous step"to back buttonaria-label="Go to next step"to next buttonaria-label="Start using DailyForge"to Let's go buttonaria-current="step"to active step dotrole="progressbar"andaria-valuenow/min/maxto progress bar<ArrowLeft>and<ArrowRight>Lucide componentsImpact it Made
Closes #1903
Closes #1905
Closes #1906
Note
Please assign this PR to the
tmdeveloper007account.