Skip to content

chore: enable windows binaries - #2118

Open
Stratus3D wants to merge 11 commits into
masterfrom
tb/windows-binaries
Open

chore: enable windows binaries#2118
Stratus3D wants to merge 11 commits into
masterfrom
tb/windows-binaries

Conversation

@Stratus3D

Copy link
Copy Markdown
Member

Fixes #1973

@Stratus3D
Stratus3D marked this pull request as ready for review June 5, 2025 00:43
@Stratus3D
Stratus3D requested a review from a team as a code owner June 5, 2025 00:43
@Stratus3D Stratus3D added this to the 0.17.1 milestone Jun 5, 2025
@Stratus3D

Copy link
Copy Markdown
Member Author

More work on CI tests is needed before this can be merged.

@Stratus3D
Stratus3D force-pushed the tb/windows-binaries branch from 7774a19 to 6ef1556 Compare July 15, 2026 02:07
Stratus3D and others added 4 commits July 20, 2026 21:24
- Change coverage output path from `/tmp/coverage.out` to `${{ runner.temp }}/coverage.out`
- Skip bash dependencies script on Windows as it's not compatible
- Fixes Windows test failures in CI

🤖 Generated with [opencode](https://opencode.ai)

Co-Authored-By: opencode <noreply@opencode.ai>
@Stratus3D
Stratus3D force-pushed the tb/windows-binaries branch from 93dc9c3 to 7a30e8a Compare July 21, 2026 01:24
@CAOShurong

Copy link
Copy Markdown

I tested the current head 7b8266f21f7a944936e34890ff514f8f580d22f3 on native Windows/amd64 with Go 1.26.5 and an isolated ASDF_DATA_DIR. To avoid conflating the result with the fixture's Bash executable, I replaced the installed dummy tool with a copy of the native Windows whoami.exe named dummy.exe, then ran reshim.

Observed:

plugin add / install / reshim / set   exit 0
asdf which dummy.exe                  exit 0, resolves the installed dummy.exe
installed dummy.exe directly          exit 0, prints the current Windows identity
asdf exec dummy.exe                   exit 1, empty stdout and stderr
generated dummy.exe shim via Git Bash exit 1, empty stdout and stderr

The executable is therefore installed and resolved, but the final execution path fails. At this head, internal/cli/cli.go:621 calls internal/exec.Exec, which calls syscall.Exec; Go's Windows implementation returns syscall.EWINDOWS unconditionally. Generated shims end in exec asdf exec ..., so they cannot complete that final execution path on native Windows even after install, reshim, and which succeed.

I made no changes to the PR; this is verification against the pinned SHA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WSL2 Migration Guide v0.16

2 participants