Added a condition to check 'numax' parameter#56
Open
virarnab wants to merge 1 commit intoashleychontos:masterfrom
Open
Added a condition to check 'numax' parameter#56virarnab wants to merge 1 commit intoashleychontos:masterfrom
virarnab wants to merge 1 commit intoashleychontos:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: Pull request
about: Contribute to this project!
title: ''
labels: ''
assignees: ''
Relevant Materials
Description
Currently,
Target.estimate_parametersrelies on theself.params['estimate']flag. When usingpySYDas a library, users often provide a numax guess afteradd_targetsbut beforeprocess_star. In this case, the flag remainsTrue, causing the automated routine to run and overwrite the user's manual guess.This PR ensures that if a numax value is manually provided, the estimation module is correctly skipped, matching the existing docstring.
Using the checklist as a guide, please provide more details about the nature of the pull request.
Attachments & Supporting Files
Please provide any relevant files i.e. data if adding a new target to a test or as an example
Other
Any other relevant context i.e. reference/link if directly addressing an existing issue
Summary Checklist:
→ Have you already submitted an issue outlining the request?
→ Did you provide the link?
* If 'Other' was selected at any point, please expand on each of these points in more detail below.
** If 'Yes' was selected for the last bullet, please elaborate below.