Skip to content

Added a condition to check 'numax' parameter#56

Open
virarnab wants to merge 1 commit intoashleychontos:masterfrom
virarnab:master
Open

Added a condition to check 'numax' parameter#56
virarnab wants to merge 1 commit intoashleychontos:masterfrom
virarnab:master

Conversation

@virarnab
Copy link
Copy Markdown

@virarnab virarnab commented Apr 8, 2026


name: Pull request
about: Contribute to this project!
title: ''
labels: ''
assignees: ''



Relevant Materials

Description

Currently, Target.estimate_parameters relies on the self.params['estimate'] flag. When using pySYD as a library, users often provide a numax guess after add_targets but before process_star. In this case, the flag remains True, causing the automated routine to run and overwrite the user's manual guess.
This PR ensures that if a numax value is manually provided, the estimation module is correctly skipped, matching the existing docstring.

Using the checklist as a guide, please provide more details about the nature of the pull request.

Attachments & Supporting Files

Please provide any relevant files i.e. data if adding a new target to a test or as an example

Other

Any other relevant context i.e. reference/link if directly addressing an existing issue


Summary Checklist:

  • Is this a major request?
    • Yes
      → Have you already submitted an issue outlining the request?
      • Yes
      • No
    • No
    • IDK
  • What type of request is this?
    • New feature
    • Modification
    • Suggested update
    • Other*
  • Why is the change needed?
    • General improvement
    • Solves a problem
    • Relevant to an open issue
      → Did you provide the link?
      • Yes
      • No
    • Increased efficiency and/or speed
    • Other?*
  • Did you test your changes?
    • Yes
    • No (please do not submit a request until you have)
    • N/A
  • Does the code comply with our style guide and is it complete with docstrings and other relevant documentation?
    • Yes
    • No
  • Will this request require any changes from our end?
    • Yes**
    • No

* If 'Other' was selected at any point, please expand on each of these points in more detail below.
** If 'Yes' was selected for the last bullet, please elaborate below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant