Fix atracdenc public path resolution in worker#97
Closed
yooamatwa-pixel wants to merge 1 commit into
Closed
Conversation
Owner
|
Bad typo - sorry about that - fixed in b54f30a |
Owner
|
The migration from Azure is still underway when it comes to web.minidisc.wiki, so I cannot update that server just yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hit this while testing local and live builds where encoding failed during worker initialisation.
This fixes atracdenc.js being resolved incorrectly from inside the ATRACDENC worker.
Before this change, the worker could attempt to load:
http://atracdenc.js/
which causes importScripts() to fail with a NetworkError.
This updates the public path handling so the worker resolves atracdenc.js against the current origin, producing paths such as:
http://localhost:5173/atracdenc.js
http://localhost:4173/atracdenc.js
Tested locally with Vite dev/preview after confirming atracdenc.js is present in public.