fix: select varied video frames for thumbnails - #24
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Video thumbnails previously used the first decoded frame, which could be blank or nearly uniform. Sample up to 10 random frames and stop when mean per-channel RGB variance reaches 400 on a 64×64 sample. If no frame qualifies, use the most varied sampled frame.
Retain the decoded frame as a fallback when duration is unavailable, and clear the seek handler during cleanup. The existing 30-second timeout still applies.
Validation: client typecheck, lint, formatting, and diff whitespace checks passed. A simulated video/canvas harness covered early acceptance, the 10-frame best-frame fallback, solid-color rejection, unknown-duration fallback, and decode-error cleanup. Real-browser video decoding has not been verified.