Refactor ServerLogin encryption injection to use @WrapOperation - #165
Open
XandarNull wants to merge 1 commit into
Open
Refactor ServerLogin encryption injection to use @WrapOperation#165XandarNull wants to merge 1 commit into
XandarNull wants to merge 1 commit into
Conversation
- Replace Redirect on Crypt.getCipher and Connection.setEncryptionKey with WrapOperation - Capture SecretKey with Local and check for null before setting up native encryption - Cancel vanilla Cipher setup via Inject in ConnectionMixin when Krypton encryption is enabled - Add MixinExtras dependency to build.gradle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey
This PR refactors
ServerLoginPacketListenerImplMixinto replace the old@Redirects with MixinExtras@WrapOperationand a standard cancellable@Inject.Unlike PR #153 , this doesn't use any
isModLoadedhacks or disable native ciphers. Velocity native encryption stays fully active and running as usual on all standard connections, but switching away from@Redirectstops Mixin from crashing when other network mods touchhandleKey.Tested on integrated server and LAN, everything connects, and native ciphers work properly.
Fixes #152