[ty] Normalize property setter and deleter wrappers#24509
Merged
charliermarsh merged 1 commit intomainfrom Apr 16, 2026
Merged
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 87.94%. The percentage of expected errors that received a diagnostic held steady at 83.21%. The number of fully passing files held steady at 79/133. |
Memory usage reportMemory usage unchanged ✅ |
|
| Project | Old Time | New Time | Change |
|---|---|---|---|
DateType |
0.04s | 0.12s | +181% |
charliermarsh
force-pushed
the
charlie/deleter-ii
branch
from
06ae273 to
9bb9a84
Compare
charliermarsh
force-pushed
the
charlie/deleter-iii
branch
from
c714ac2 to
c9146b8
Compare
charliermarsh
force-pushed
the
charlie/deleter-ii
branch
from
9bb9a84 to
1c52e2f
Compare
charliermarsh
force-pushed
the
charlie/deleter-iii
branch
3 times, most recently
from
0955ad4 to
df18f81
Compare
charliermarsh
requested review from
AlexWaygood,
carljm,
dcreager,
ibraheemdev and
sharkdp
as code owners
charliermarsh
force-pushed
the
charlie/deleter-iii
branch
from
df18f81 to
8a176c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Setters and deleters always return
None, even if the user returns a different type or annotates it with a different type. We now normalize the return type (while retainingNeverorNoReturn, so we can detect invalid deletions).