E2E smoke specs for the new UI features#42
Merged
Conversation
Playwright smoke specs (e2e/smoke, data-testid selectors) for the features added this cycle: - command-palette: Ctrl+K opens, filters by keyword, navigates; Esc closes - settings-about: version + links + QR share modal + Developer Mode persist - settings-appearance: palette + dark mode flip data-app-theme/data-theme - settings-data-and-feature: backup/cache controls + cache-clear confirm; the disabled feature-section demo on the General tab PWA update/install prompts (event-driven) + ErrorBoundary stay unit-tested only. All referenced testids verified against the source. Run via the e2e webServer: cd e2e && npx playwright test --project=smoke. Closes #41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #41
Closes the one real gap from the post-session audit: the features added this cycle had strong Vitest coverage but no Playwright smoke specs (AL convention: every UI feature gets one).
Adds
e2e/smoke/specs (data-testid selectors, matching the existing smoke pattern):data-app-theme/data-theme.PWA update/install prompts (event-driven, not user-reachable in a smoke run) + ErrorBoundary stay unit-tested only.
Verified: every
data-testidthe specs reference exists in the source (incl. the dynamicabout-link-repo,command-nav-*,feature-sync-demo-reason). Per the e2e convention these run against the auto-started stack:cd e2e && npx playwright test --project=smoke— they need a running backend+frontend, so they aren't executed in this PR's authoring environment.