fix(docs): correct Puppeteer env var from PUPPETEER_SKIP_CHROMIUM_DOWNLOAD to PUPPETEER_SKIP_DOWNLOAD (#794) - #805
Conversation
…NLOAD to PUPPETEER_SKIP_DOWNLOAD (asyncapi#794) PUPPETEER_SKIP_CHROMIUM_DOWNLOAD is deprecated in puppeteer@^24.4.0. The correct variable is PUPPETEER_SKIP_DOWNLOAD.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
|
This pull request has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation. There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
1 participant
Problem
Fixes #794
The README instructs users to set
PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true, but this environment variable is deprecated in puppeteer@^24.4.0. Setting it has no effect — Chromium is still downloaded.Fix
Replace with
PUPPETEER_SKIP_DOWNLOAD=true, which is the correct variable in modern Puppeteer versions.Verification
PUPPETEER_SKIP_DOWNLOADis the correct variablePUPPETEER_SKIP_DOWNLOAD=true npm installcorrectly skips Chromium download