Split ArcCanvas.jsx into per-component files (#2835)#2862
Merged
Conversation
# Conflicts: # .changelog/NEXT.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
client/src/components/pipeline/ArcCanvas.jsxhad grown to ~2875 lines holding 32 top-level components/helpers. This is a pure mechanical, behavior-preserving split: each subcomponent now lives in its own file underclient/src/components/pipeline/arcCanvas/, following the one-concern-per-file convention.shared.js(holds theSEVERITY_COLORSmap used by bothVerifyResultsandCompletenessResults).VERIFY_ARC_SCOPEinArcHeader.jsx,ISSUE_STATUS_COLORS/issueCoverRecordinIssueRow.jsx,pickRenderedFilename/pickCoverJobIdinCoverArt.jsx, the cover-slot reducers inVolumeCoverLiveUpdates.jsx).ArcCanvas.jsx(default export) is now a thin 122-line composer.ArcRoadmapChartis re-exported fromArcCanvas.jsxso its existing public import path ({ ArcRoadmapChart } from '.../ArcCanvas', used byPipelineSeriesRoadmap) keeps working. The default export path (used byPipelineSeries,StoryBuilder) is unchanged.No rendered-output change — component code is copied verbatim; only import depths were adjusted (
arcCanvas/is one level deeper thanpipeline/).Test plan
cd client && npm test— 416 files / 4555 tests pass.npx eslintoverArcCanvas.jsx+arcCanvas/— clean (no unused/undefined imports).cd client && npm run build— production build succeeds, confirming theArcRoadmapChartre-export and all sibling imports resolve.Closes #2835