refactor: extract helpers from generateManagedAppImprovementTaskForType (#2836)#2864
Open
atomantic wants to merge 2 commits into
Open
refactor: extract helpers from generateManagedAppImprovementTaskForType (#2836)#2864atomantic wants to merge 2 commits into
atomantic wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generateManagedAppImprovementTaskForType()inserver/services/cosTaskGenerator.jshad grown to ~533 lines, mixing metadata assembly, override sanitization, precondition/perpetual-work gating, deterministic reconcile pre-steps, and watcher polling in one function. This extracts that logic into named helpers (mirroring existing siblings likecheckStagePrecondition), leaving the main function a thin orchestrator.New module-level helpers (all behavior-preserving, moved verbatim):
buildImprovementTaskMetadata— base metadata + sanitized global/per-app override mergeresolveTaskInputHook— buildTaskInput hook ({ skip }/{ hookPrompt, hookOverride })resolveClaimWorkRouting— claim-work single-source router →promptTaskTypeapplyPerpetualWorkGate— perpetual drain work-detector gateresolveBranchReconcileBlock/resolveIssueReconcileBlock— deterministic reconcile pre-stepsresolveReferenceWatchBlock/resolvePrWatcherBlock— watcher polling + prompt-block injectionEach gate-checking helper returns a discriminated
{ skip }result the orchestrator forwards as itsreturn null, and the block-producing helpers return an empty block for non-matching task types — so dispatch ordering, park/convergence semantics, cadence recording, and every early-return path are unchanged.Test plan
cd server && npm test -- cosTaskGenerator— 63 pass (source-pinned wiring guards for claim-work routing, {reviewers} interpolation, swarm block, model-literal, etc. all still green)cd server && npm test -- cosTask cos.test taskSchedule— 510 pass across 8 suitesCloses #2836