virtio/block: fix another deadlock#282
Open
dreamliner787-9 wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
Hmm that's annoying, the virtio block tests pass in the hardware CI now. But a couple of other tests in release configuration is failing, presumably due to this #231. |
dreamliner787-9
changed the title
dreamliner787-9
changed the title
The arena allocator in sDDF is used for allocating variable sized chunks in unit of sDDF transfer window size within the sDDF Block data region for servicing read and write requests. Previously there is a bug in this allocator where it would report that there are no free space while there are plenty remaining. That would cause the a block request from the guest to fail over and over. Which can deadlock the guest. That bug has now been fixed in sDDF and this commit update sDDF to contain the fix. Signed-off-by: Bill Nguyen <bill.nguyen@unsw.edu.au>
dreamliner787-9
force-pushed
the
virtio_blk_fix
branch
from
adfdb44 to
ff01779
Compare
Collaborator
Author
|
Great hardware CI seems stable now that #284 is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The arena allocator in sDDF is used for allocating variable sized chunks in unit of sDDF transfer window size within the sDDF Block data region for servicing read and write requests.
Previously there is a bug in this allocator where it would report that there are no free space while there are plenty remaining. That would cause the a block request from the guest to fail over and over. Which can deadlock the guest.
That bug has now been fixed in sDDF and this commit update sDDF to contain the fix.
Closes #263.
Thanks @Courtney3141 for implementing the fix on sDDF.
au-ts/sddf#741 will need to be merged and hardware CI passing before this can me merged.