test: fix e2e - #447
Closed
miparnisari wants to merge 2 commits into
Closed
Conversation
miparnisari
commented
Sep 1, 2026
| v1alpha1ClusterGVR, | ||
| corev1.SchemeGroupVersion.WithResource("pods"), | ||
| corev1.SchemeGroupVersion.WithResource("jobs"), | ||
| batchv1.SchemeGroupVersion.WithResource("jobs"), |
Contributor
Author
There was a problem hiding this comment.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
miparnisari
enabled auto-merge
September 1, 2026 23:54
alecmerdler
previously approved these changes
Sep 2, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 2, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 2, 2026
miparnisari
enabled auto-merge
September 2, 2026 03:53
Contributor
|
These changes are also in #446 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the cluster-state dump that runs when an e2e spec fails.
SnapshotFailHandlerlisted jobs undercore/v1, which doesn't exist, so every dump logged "the server could not find the requested resource".SaveClusterStatethen fell through and ranged over the nil list, faulting inside the failure handler. Ginkgo recorded the fault's stack location (e2e_test.go:469orruntime/signal_unix.go) instead of the real failing assertion, and the dump never completed.