Skip to content

feat(helm): Add SDK client-side rate limiting to Helm chart templates #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NicholasBlaskey wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(helm): Add SDK client-side rate limiting to Helm chart templates #727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions templates/helm/templates/deployment.yaml.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,14 @@ spec:
- --reconcile-default-max-concurrent-syncs
- "$(RECONCILE_DEFAULT_MAX_CONCURRENT_SYNCS)"
{{ "{{- end }}" }}
{{ "{{- if .Values.aws.sdkMaxTPS }}" }}
- --sdk-max-tps
- "$(ACK_SDK_MAX_TPS)"
{{ "{{- end }}" }}
{{ "{{- if .Values.aws.sdkMaxBurst }}" }}
- --sdk-max-burst
- "$(ACK_SDK_MAX_BURST)"
{{ "{{- end }}" }}
{{ "{{- range $key, $value := .Values.reconcile.resourceMaxConcurrentSyncs }}" }}
- --reconcile-resource-max-concurrent-syncs
- {{ "\"$(RECONCILE_RESOURCE_MAX_CONCURRENT_SYNCS_{{ $key | upper }})\"" }}
Expand Down Expand Up @@ -124,6 +132,14 @@ spec:
value: {{ "{{ .Values.aws.endpoint_url | quote }}" }}
- name: AWS_IDENTITY_ENDPOINT_URL
value: {{ "{{ .Values.aws.identity_endpoint_url | quote }}" }}
{{ "{{- if .Values.aws.sdkMaxTPS }}" }}
- name: ACK_SDK_MAX_TPS
value: {{ "{{ .Values.aws.sdkMaxTPS | quote }}" }}
{{ "{{- end }}" }}
{{ "{{- if .Values.aws.sdkMaxBurst }}" }}
- name: ACK_SDK_MAX_BURST
value: {{ "{{ .Values.aws.sdkMaxBurst | quote }}" }}
{{ "{{- end }}" }}
- name: ACK_WATCH_NAMESPACE
value: {{ IncludeTemplate "watch-namespace" }}
- name: ACK_WATCH_SELECTORS
Expand Down
8 changes: 8 additions & 0 deletions templates/helm/values.yaml.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,14 @@ aws:
{{- if eq .ControllerName "s3" }}
endpoint_use_path_style: false
{{- end }}
# Client-side rate limiting for AWS SDK API calls.
# Limits the maximum request rate to the AWS service API.
# Useful for services with low account-level rate limits.
# For example, Route53 enforces 5 req/s account-wide — setting sdkMaxTPS: 3
# leaves headroom for other consumers (external-dns, Terraform, etc.).
# Set to 0 or leave commented to disable (default).
# sdkMaxTPS: 3
# sdkMaxBurst: 5
credentials:
# If specified, Secret with shared credentials file to use.
secretName: ""
Expand Down