Skip to content

Fix config/crd/bases vs helm/crds list-marker mismatch (gofmt ordering) #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HansG89 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix config/crd/bases vs helm/crds list-marker mismatch (gofmt ordering) #737

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions scripts/build-controller.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,16 @@ if ! $ACK_GENERATE_BIN_PATH "${apis_args[@]}"; then
exit 2
fi

# gofmt rewrites Markdown-style list markers in doc comments (e.g. "*" -> "-")
# as part of its doc-comment formatting. Run it here, before the CRD schemas
# are generated from these doc comments, so that this controller-gen run and
# the later one in build-controller-release.sh (which reads the same,
# already-gofmt'd source) produce identical description text. Otherwise the
# two output targets (config/crd/bases and helm/crds) capture the doc
# comments on opposite sides of this rewrite and permanently disagree on
# list-marker style for the same enum text.
gofmt -w "$SERVICE_CONTROLLER_SOURCE_PATH/apis/$ACK_GENERATE_API_VERSION"

pushd "$SERVICE_CONTROLLER_SOURCE_PATH/apis/$ACK_GENERATE_API_VERSION" 1>/dev/null

echo "Generating deepcopy code for $SERVICE"
Expand Down