fix: key LaunchTemplate by Name so adopt-or-create works - #347
Open
michaelhtm wants to merge 1 commit into
Open
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
michaelhtm
force-pushed
the
fix/launch-template-adopt-by-name
branch
from
June 24, 2026 20:31
3a993ca to
3a36dae
Compare
Member
Author
|
/retest |
michaelhtm
force-pushed
the
fix/launch-template-adopt-by-name
branch
from
June 25, 2026 16:46
3a36dae to
9845060
Compare
Member
Author
|
/label release/patch |
ack-prow
Bot
added
the
release/patch
LaunchTemplate was keyed by Status.ID, so sdkFind short-circuited to NotFound whenever the ID was unset and adopt-or-create looped on CreateLaunchTemplate AlreadyExistsException. Make the unique Name the primary key (immutable, since AWS cannot rename templates) so sdkFind reads by name and adopts a pre-existing template. Also stop DescribeLaunchTemplateVersions from running unfiltered when the template identifier is unknown, which would clobber Spec.Data with unrelated data. Resolves aws-controllers-k8s/community#2932
michaelhtm
force-pushed
the
fix/launch-template-adopt-by-name
branch
from
June 25, 2026 20:19
9845060 to
53de950
Compare
Member
Author
|
/retest |
Member
Author
|
/label release/patch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
LaunchTemplate was keyed by Status.ID, so sdkFind short-circuited to
NotFound whenever the ID was unset and adopt-or-create looped on
CreateLaunchTemplate AlreadyExistsException. Make the unique Name the
primary key (immutable, since AWS cannot rename templates) so sdkFind
reads by name and adopts a pre-existing template. Also stop
DescribeLaunchTemplateVersions from running unfiltered when the template
identifier is unknown, which would clobber Spec.Data with unrelated data.
Resolves aws-controllers-k8s/community#2932
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.