Skip to content

Add test documentation and setup helper scripts - #203

Open
willthames wants to merge 1 commit into
aws-controllers-k8s:mainfrom
willthames:make-test-setup-easier
Open

Add test documentation and setup helper scripts#203
willthames wants to merge 1 commit into
aws-controllers-k8s:mainfrom
willthames:make-test-setup-easier

Conversation

@willthames

Copy link
Copy Markdown

Description of changes:

Add setup.sh, pickle.sh and teardown.sh scripts to help manage test infrastructure

Update all configuration to allow flexible regions (no longer hard-coding to us-west-2)

Update S3 object hash management to store checksum alongside S3 object and use that to validate lambda hashes.

Issue #, if available: N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow
ack-prow Bot requested review from knottnt and michaelhtm February 25, 2026 00:50
@ack-prow ack-prow Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 25, 2026
@ack-prow

ack-prow Bot commented Feb 25, 2026

Copy link
Copy Markdown

Hi @willthames. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@willthames

Copy link
Copy Markdown
Author

If need be, I can also split this into two PRs, one that is the script and the docs, and one that fixes the tests (allowing other regions, fixing the sha256 hash checks)

@ack-bot

ack-bot commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Issues go stale after 180d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 60d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale

@ack-prow ack-prow Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 24, 2026
@willthames

Copy link
Copy Markdown
Author

/remove-lifecycle stale

@ack-prow ack-prow Bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 24, 2026
Add setup.sh, pickle.sh and teardown.sh scripts to help manage test
infrastructure

Update all configuration to allow flexible regions (no longer
hard-coding to us-west-2)

Update S3 object hash management to store checksum alongside S3
object and use that to validate lambda hashes.
@willthames
willthames force-pushed the make-test-setup-easier branch from ee2c413 to 0ab2e32 Compare August 24, 2026 04:19
@ack-prow

ack-prow Bot commented Aug 24, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: willthames
Once this PR has been reviewed and has the lgtm label, please assign jlbutler for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants