feat: make ARN unique identifier for AWS Resource Shares

[ramasai1]

We're using ACK team based CARM, where a single namespace is mapped to a team. Each team is creating a ResourceShare CR with the same name in their VPC, but the RAM controller is querying for ResourceShares via the .spec.Name key. This makes it such that all of the ResourceShare objects in all namespaces end up getting the same ARN, and the resources shared get overwritten.

We should be matching on ARN and not on the name, since thats a unique identifier for the share. If the ID of the share was available as a standalone field (similar to VPC ID) then things would have been easier.

[ack-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ramasai1
Once this PR has been reviewed and has the lgtm label, please assign sapphirew for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ack-prow]

Hi @ramasai1. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ramasai1]

The existing tests should pass - I am expecting this to be a transparent change for both resource shares that exist and new resource shares being created.

[ramasai1]

Hello @a-hilaly - looking to get some early thoughts from you about the feasibility of this change, thanks.