fix(ci): run E2E matrix when CI workflow definitions change - #474
Open
Simone319 wants to merge 1 commit into
Open
fix(ci): run E2E matrix when CI workflow definitions change#474Simone319 wants to merge 1 commit into
Simone319 wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gap
pr-checks.yml'sDetect Changesjob gates every expensive E2E job (E2E Templates,E2E Sandbox,E2E Sandbox (VPC Smoke),E2E Production,E2E Supabase,E2E Hosting (...)matrix,Telemetry E2E) onneeds.detect-changes.outputs.source-changed == 'true'. That output came from:So a PR that only edits
.github/workflows/**producedsource-changed=falseand the entire E2E matrix was skipped (and theBuild and Testgate treats skipped E2E jobs as passing).That is how PRs #465/#466 (commits 327f061 / 7401d30) changed CI behaviour — turning stale-stack reuse into fresh CREATEs in
cleanup-stacks.yml— without a single E2E job ever running against the new behaviour. The resulting hosting regression (aws-cdk#15891 class) only surfaced later on #391/#460/#459.The fix
Treat CI-definition changes that actually affect the E2E jobs as source changes:
.github/workflows/pr-checks.yml— the workflow defining the E2E jobs themselves.github/workflows/cleanup-stacks.yml— the stale-stack cleanup that determines whether E2E deploys reuse or freshly CREATE stacks.github/actions/— composite actions the E2E jobsuses:(e.g.seed-telemetry-id)Alternative considered
A blanket
.github/workflows/**rule. Rejected: it would run the full, expensive E2E matrix (6-way hosting matrix + sandbox/production/supabase/telemetry AWS deploys) on every unrelated workflow edit — issue triage, publishing, docs bots, stale-issue lockers. The explicit list is the minimal set that actually influences E2E outcomes.Notes
.github/workflows/pr-checks.yml— nothing underpackages/, so no changeset is required (changeset-guard only tracks^packages/([^/]+)/).lock.ymlorREADME.md).pr-checks.yml, so it should now self-trigger the E2E matrix — a live demonstration of the fix.