fix(bb-cron-job): grant scheduler role access to all computes - #517
Open
ikenyal wants to merge 1 commit into
Open
fix(bb-cron-job): grant scheduler role access to all computes#517ikenyal wants to merge 1 commit into
ikenyal wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 0ba429b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After #459, CronJob correctly targets its resolved Lambda compute. The Scheduler IAM role remains shared per stack, however, and only receives
lambda:InvokeFunctionfor the first CronJob target. A later CronJob targeting a different resolved Lambda synthesizes a correct schedule target but lacks permission for EventBridge Scheduler to invoke it.Issue #: N/A
Changes
lambda:InvokeFunctiongrant for each distinct CronJob target compute while preserving the existing single shared role per stack.@aws-blocks/bb-cron-job.Validation
npm run build --workspace @aws-blocks/bb-cron-jobnpm test --workspace @aws-blocks/bb-cron-job(65 passing)npm run lintnpm run lint:depsnpx changeset status --since=origin/maingit diff --checkChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.