fix(efa): use full IAM role names to avoid 38-char name_prefix cap#726
Open
sky333999 wants to merge 1 commit into
Open
fix(efa): use full IAM role names to avoid 38-char name_prefix cap#726sky333999 wants to merge 1 commit into
sky333999 wants to merge 1 commit into
Conversation
sky333999
force-pushed
the
efa-name-prefix-fix
branch
from
July 17, 2026 23:34
6b4c8b3 to
dff5b58
Compare
Standardizing the efa and otel-multi-efa cluster names to the shared cwagent-eks-integ- prefix (#721) pushed the terraform-aws-modules/eks v21 derived cluster IAM role name_prefix "<name>-cluster-" to 43 chars, over the 38-char name_prefix limit, so terraform apply fails before the tests run: expected length of name_prefix to be in the range (1 - 38), got cwagent-eks-integ-<id>-cluster-. Set iam_role_use_name_prefix = false on the eks module (cluster) and on the managed node groups so the module uses the full role name (<= 64) instead of the 38-capped prefix. The standardized cluster name is unchanged, so the cluster-cleaner allowlist from #721 still matches. Only the two module-based EFA clusters were affected; other EKS tests use raw aws_eks_cluster with explicitly-named IAM roles.
sky333999
force-pushed
the
efa-name-prefix-fix
branch
from
July 17, 2026 23:36
dff5b58 to
fec0fd5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
#721 standardized the
efaandotel-multi-efaEKS integration-test cluster names to the sharedcwagent-eks-integ-prefix so the cluster-cleaner allowlist covers them. But those two tests build theircluster via the
terraform-aws-modules/eksv21 module, which derives the cluster IAM role name from"<cluster-name>-cluster-"as an IAM rolename_prefix(max 38 chars). The standardized name makes that43 chars, so
terraform applyfails before the test runs:Only these two tests are affected — every other EKS test uses a raw
aws_eks_clusterwith anexplicitly-named IAM role (
name, 64-char limit), not the module's 38-cappedname_prefix.Fix: set
iam_role_use_name_prefix = falseon the eks module (cluster) and on each managed node group, sothe module uses the full role name (IAM limit 64) instead of the 38-capped prefix. The standardized cluster
name is unchanged, so #721's cluster-cleaner allowlist still matches.
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this
contribution, under the terms of your choice.
Tests