Skip to content

[integ-test] Make get-cluster/image-log-events integ tests robust to empty pages - #7642

Merged
hanwen-cluster merged 1 commit into
aws:developfrom
hanwen-cluster:developsep28
Sep 28, 2026
Merged

hanwen-cluster merged 1 commit into
aws:developfrom
hanwen-cluster:developsep28

Conversation

@hanwen-cluster

Copy link
Copy Markdown
Contributor

Description of changes

GetLogEvents may return partially full or empty pages even when more events are available; limit is only an upper bound. The previous checks assumed limit=1 always returned exactly one event and indexed events[0], making them flaky.

Replace the filter matrix with a full pagination of the log stream (until the returned token equals the one passed in) and assert the stream is not empty. Arguments like limit are already covered by unit tests, and don't have to be in integration tests.

Tests

  • Ongoing

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…empty pages

GetLogEvents may return partially full or empty pages even when more events are available; `limit` is only an upper bound. The previous checks assumed `limit=1` always returned exactly one event and indexed `events[0]`, making them flaky.

Replace the filter matrix with a full pagination of the log stream (until the returned token equals the one passed in) and assert the stream is not empty. Arguments like `limit` are already covered by unit tests, and don't have to be in integration tests.
@hanwen-cluster
hanwen-cluster requested review from a team as code owners September 28, 2026 13:50
@hanwen-cluster hanwen-cluster added the skip-changelog-update Disables the check that enforces changelog updates in PRs label Sep 28, 2026
@hanwen-cluster
hanwen-cluster enabled auto-merge (rebase) September 28, 2026 20:34
@hanwen-cluster
hanwen-cluster merged commit 61a7c98 into aws:develop Sep 28, 2026
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog-update Disables the check that enforces changelog updates in PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants