Skip to content

Fix invoke service operation for smithy clients #3811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbaluja merged 2 commits into from
Apr 30, 2026
Merged

Fix invoke service operation for smithy clients #3811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fdce5ac
Add codegen for smithy InvokeServiceOperation
sbaluja Apr 29, 2026
588a3aa
Updated smithy clients
sbaluja Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...p-sdk-bedrock-agent-runtime/include/aws/bedrock-agent-runtime/BedrockAgentRuntimeClient.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1069,6 +1069,12 @@ class AWS_BEDROCKAGENTRUNTIME_API BedrockAgentRuntimeClient

private:
friend class Aws::Client::ClientWithAsyncTemplateMethods<BedrockAgentRuntimeClient>;

typedef Aws::Utils::Outcome<Aws::AmazonWebServiceResult<Aws::Utils::Json::JsonValue>, BedrockAgentRuntimeError> InvokeOperationOutcome;

InvokeOperationOutcome InvokeServiceOperation(const AmazonWebServiceRequest& request,
const std::function<void(Aws::Endpoint::AWSEndpoint&)>& resolveUri,
Aws::Http::HttpMethod httpMethod) const;
};

} // namespace BedrockAgentRuntime
Expand Down
922 changes: 268 additions & 654 deletions generated/src/aws-cpp-sdk-bedrock-agent-runtime/source/BedrockAgentRuntimeClient.cpp
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 6 additions & 0 deletions generated/src/aws-cpp-sdk-bedrock-agent/include/aws/bedrock-agent/BedrockAgentClient.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2187,6 +2187,12 @@ class AWS_BEDROCKAGENT_API BedrockAgentClient

private:
friend class Aws::Client::ClientWithAsyncTemplateMethods<BedrockAgentClient>;

typedef Aws::Utils::Outcome<Aws::AmazonWebServiceResult<Aws::Utils::Json::JsonValue>, BedrockAgentError> InvokeOperationOutcome;

InvokeOperationOutcome InvokeServiceOperation(const AmazonWebServiceRequest& request,
const std::function<void(Aws::Endpoint::AWSEndpoint&)>& resolveUri,
Aws::Http::HttpMethod httpMethod) const;
};

} // namespace BedrockAgent
Expand Down
2,557 changes: 736 additions & 1,821 deletions generated/src/aws-cpp-sdk-bedrock-agent/source/BedrockAgentClient.cpp
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 5 additions & 0 deletions ...-runtime/include/aws/bedrock-data-automation-runtime/BedrockDataAutomationRuntimeClient.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,11 @@ class AWS_BEDROCKDATAAUTOMATIONRUNTIME_API BedrockDataAutomationRuntimeClient

private:
friend class Aws::Client::ClientWithAsyncTemplateMethods<BedrockDataAutomationRuntimeClient>;

typedef Aws::Utils::Outcome<Aws::AmazonWebServiceResult<Aws::Utils::Json::JsonValue>, BedrockDataAutomationRuntimeError>
InvokeOperationOutcome;

InvokeOperationOutcome InvokeServiceOperation(const AmazonWebServiceRequest& request, Aws::Http::HttpMethod httpMethod) const;
};

} // namespace BedrockDataAutomationRuntime
Expand Down
174 changes: 42 additions & 132 deletions ...aws-cpp-sdk-bedrock-data-automation-runtime/source/BedrockDataAutomationRuntimeClient.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,153 +146,63 @@ void BedrockDataAutomationRuntimeClient::OverrideEndpoint(const Aws::String& end
m_clientConfiguration.endpointOverride = endpoint;
m_endpointProvider->OverrideEndpoint(endpoint);
}
GetDataAutomationStatusOutcome BedrockDataAutomationRuntimeClient::GetDataAutomationStatus(
const GetDataAutomationStatusRequest& request) const {
AWS_OPERATION_GUARD(GetDataAutomationStatus);
AWS_OPERATION_CHECK_PTR(m_endpointProvider, GetDataAutomationStatus, CoreErrors, CoreErrors::ENDPOINT_RESOLUTION_FAILURE);
AWS_OPERATION_CHECK_PTR(m_clientConfiguration.telemetryProvider, GetDataAutomationStatus, CoreErrors, CoreErrors::NOT_INITIALIZED);
auto tracer = m_clientConfiguration.telemetryProvider->getTracer(this->GetServiceClientName(), {});
auto meter = m_clientConfiguration.telemetryProvider->getMeter(this->GetServiceClientName(), {});
AWS_OPERATION_CHECK_PTR(meter, GetDataAutomationStatus, CoreErrors, CoreErrors::NOT_INITIALIZED);
auto span = tracer->CreateSpan(Aws::String(this->GetServiceClientName()) + ".GetDataAutomationStatus",
{{TracingUtils::SMITHY_METHOD_DIMENSION, request.GetServiceRequestName()},
{TracingUtils::SMITHY_SERVICE_DIMENSION, this->GetServiceClientName()},
BedrockDataAutomationRuntimeClient::InvokeOperationOutcome BedrockDataAutomationRuntimeClient::InvokeServiceOperation(
const AmazonWebServiceRequest& request, Aws::Http::HttpMethod httpMethod) const {
auto operationName = request.GetServiceRequestName();
auto serviceName = GetServiceClientName();

AWS_OPERATION_GUARD_DYNAMIC(operationName);

AWS_OPERATION_CHECK_PTR_DYNAMIC(m_clientConfiguration.telemetryProvider, operationName, CoreErrors, CoreErrors::NOT_INITIALIZED);

auto tracer = m_clientConfiguration.telemetryProvider->getTracer(serviceName, {});
auto meter = m_clientConfiguration.telemetryProvider->getMeter(serviceName, {});
AWS_OPERATION_CHECK_PTR_DYNAMIC(meter, operationName, CoreErrors, CoreErrors::NOT_INITIALIZED);

auto span = tracer->CreateSpan(Aws::String(serviceName) + "." + operationName,
{{TracingUtils::SMITHY_METHOD_DIMENSION, operationName},
{TracingUtils::SMITHY_SERVICE_DIMENSION, serviceName},
{TracingUtils::SMITHY_SYSTEM_DIMENSION, TracingUtils::SMITHY_METHOD_AWS_VALUE}},
smithy::components::tracing::SpanKind::CLIENT);
return TracingUtils::MakeCallWithTiming<GetDataAutomationStatusOutcome>(
[&]() -> GetDataAutomationStatusOutcome {

return TracingUtils::MakeCallWithTiming<InvokeOperationOutcome>(
[&]() -> InvokeOperationOutcome {
auto result =
MakeRequestDeserialize(&request, request.GetServiceRequestName(), Aws::Http::HttpMethod::HTTP_POST,
MakeRequestDeserialize(&request, operationName, httpMethod,
[&](Aws::Endpoint::AWSEndpoint& resolvedEndpoint) -> void { AWS_UNREFERENCED_PARAM(resolvedEndpoint); });
return result.IsSuccess() ? GetDataAutomationStatusOutcome(result.GetResultWithOwnership())
: GetDataAutomationStatusOutcome(std::move(result.GetError()));
return result.IsSuccess() ? InvokeOperationOutcome(result.GetResultWithOwnership())
: InvokeOperationOutcome(std::move(result.GetError()));
},
TracingUtils::SMITHY_CLIENT_DURATION_METRIC, *meter,
{{TracingUtils::SMITHY_METHOD_DIMENSION, request.GetServiceRequestName()},
{TracingUtils::SMITHY_SERVICE_DIMENSION, this->GetServiceClientName()}});
{{TracingUtils::SMITHY_METHOD_DIMENSION, operationName}, {TracingUtils::SMITHY_SERVICE_DIMENSION, serviceName}});
}
GetDataAutomationStatusOutcome BedrockDataAutomationRuntimeClient::GetDataAutomationStatus(
const GetDataAutomationStatusRequest& request) const {
auto result = InvokeServiceOperation(request, Aws::Http::HttpMethod::HTTP_POST);
return result.IsSuccess() ? GetDataAutomationStatusOutcome(result.GetResultWithOwnership())
: GetDataAutomationStatusOutcome(std::move(result.GetError()));
}

InvokeDataAutomationOutcome BedrockDataAutomationRuntimeClient::InvokeDataAutomation(const InvokeDataAutomationRequest& request) const {
AWS_OPERATION_GUARD(InvokeDataAutomation);
AWS_OPERATION_CHECK_PTR(m_endpointProvider, InvokeDataAutomation, CoreErrors, CoreErrors::ENDPOINT_RESOLUTION_FAILURE);
AWS_OPERATION_CHECK_PTR(m_clientConfiguration.telemetryProvider, InvokeDataAutomation, CoreErrors, CoreErrors::NOT_INITIALIZED);
auto tracer = m_clientConfiguration.telemetryProvider->getTracer(this->GetServiceClientName(), {});
auto meter = m_clientConfiguration.telemetryProvider->getMeter(this->GetServiceClientName(), {});
AWS_OPERATION_CHECK_PTR(meter, InvokeDataAutomation, CoreErrors, CoreErrors::NOT_INITIALIZED);
auto span = tracer->CreateSpan(Aws::String(this->GetServiceClientName()) + ".InvokeDataAutomation",
{{TracingUtils::SMITHY_METHOD_DIMENSION, request.GetServiceRequestName()},
{TracingUtils::SMITHY_SERVICE_DIMENSION, this->GetServiceClientName()},
{TracingUtils::SMITHY_SYSTEM_DIMENSION, TracingUtils::SMITHY_METHOD_AWS_VALUE}},
smithy::components::tracing::SpanKind::CLIENT);
return TracingUtils::MakeCallWithTiming<InvokeDataAutomationOutcome>(
[&]() -> InvokeDataAutomationOutcome {
auto result =
MakeRequestDeserialize(&request, request.GetServiceRequestName(), Aws::Http::HttpMethod::HTTP_POST,
[&](Aws::Endpoint::AWSEndpoint& resolvedEndpoint) -> void { AWS_UNREFERENCED_PARAM(resolvedEndpoint); });
return result.IsSuccess() ? InvokeDataAutomationOutcome(result.GetResultWithOwnership())
: InvokeDataAutomationOutcome(std::move(result.GetError()));
},
TracingUtils::SMITHY_CLIENT_DURATION_METRIC, *meter,
{{TracingUtils::SMITHY_METHOD_DIMENSION, request.GetServiceRequestName()},
{TracingUtils::SMITHY_SERVICE_DIMENSION, this->GetServiceClientName()}});
auto result = InvokeServiceOperation(request, Aws::Http::HttpMethod::HTTP_POST);
return result.IsSuccess() ? InvokeDataAutomationOutcome(result.GetResultWithOwnership())
: InvokeDataAutomationOutcome(std::move(result.GetError()));
}

InvokeDataAutomationAsyncOutcome BedrockDataAutomationRuntimeClient::InvokeDataAutomationAsync(
const InvokeDataAutomationAsyncRequest& request) const {
AWS_OPERATION_GUARD(InvokeDataAutomationAsync);
AWS_OPERATION_CHECK_PTR(m_endpointProvider, InvokeDataAutomationAsync, CoreErrors, CoreErrors::ENDPOINT_RESOLUTION_FAILURE);
AWS_OPERATION_CHECK_PTR(m_clientConfiguration.telemetryProvider, InvokeDataAutomationAsync, CoreErrors, CoreErrors::NOT_INITIALIZED);
auto tracer = m_clientConfiguration.telemetryProvider->getTracer(this->GetServiceClientName(), {});
auto meter = m_clientConfiguration.telemetryProvider->getMeter(this->GetServiceClientName(), {});
AWS_OPERATION_CHECK_PTR(meter, InvokeDataAutomationAsync, CoreErrors, CoreErrors::NOT_INITIALIZED);
auto span = tracer->CreateSpan(Aws::String(this->GetServiceClientName()) + ".InvokeDataAutomationAsync",
{{TracingUtils::SMITHY_METHOD_DIMENSION, request.GetServiceRequestName()},
{TracingUtils::SMITHY_SERVICE_DIMENSION, this->GetServiceClientName()},
{TracingUtils::SMITHY_SYSTEM_DIMENSION, TracingUtils::SMITHY_METHOD_AWS_VALUE}},
smithy::components::tracing::SpanKind::CLIENT);
return TracingUtils::MakeCallWithTiming<InvokeDataAutomationAsyncOutcome>(
[&]() -> InvokeDataAutomationAsyncOutcome {
auto result =
MakeRequestDeserialize(&request, request.GetServiceRequestName(), Aws::Http::HttpMethod::HTTP_POST,
[&](Aws::Endpoint::AWSEndpoint& resolvedEndpoint) -> void { AWS_UNREFERENCED_PARAM(resolvedEndpoint); });
return result.IsSuccess() ? InvokeDataAutomationAsyncOutcome(result.GetResultWithOwnership())
: InvokeDataAutomationAsyncOutcome(std::move(result.GetError()));
},
TracingUtils::SMITHY_CLIENT_DURATION_METRIC, *meter,
{{TracingUtils::SMITHY_METHOD_DIMENSION, request.GetServiceRequestName()},
{TracingUtils::SMITHY_SERVICE_DIMENSION, this->GetServiceClientName()}});
auto result = InvokeServiceOperation(request, Aws::Http::HttpMethod::HTTP_POST);
return result.IsSuccess() ? InvokeDataAutomationAsyncOutcome(result.GetResultWithOwnership())
: InvokeDataAutomationAsyncOutcome(std::move(result.GetError()));
}

ListTagsForResourceOutcome BedrockDataAutomationRuntimeClient::ListTagsForResource(const ListTagsForResourceRequest& request) const {
AWS_OPERATION_GUARD(ListTagsForResource);
AWS_OPERATION_CHECK_PTR(m_endpointProvider, ListTagsForResource, CoreErrors, CoreErrors::ENDPOINT_RESOLUTION_FAILURE);
AWS_OPERATION_CHECK_PTR(m_clientConfiguration.telemetryProvider, ListTagsForResource, CoreErrors, CoreErrors::NOT_INITIALIZED);
auto tracer = m_clientConfiguration.telemetryProvider->getTracer(this->GetServiceClientName(), {});
auto meter = m_clientConfiguration.telemetryProvider->getMeter(this->GetServiceClientName(), {});
AWS_OPERATION_CHECK_PTR(meter, ListTagsForResource, CoreErrors, CoreErrors::NOT_INITIALIZED);
auto span = tracer->CreateSpan(Aws::String(this->GetServiceClientName()) + ".ListTagsForResource",
{{TracingUtils::SMITHY_METHOD_DIMENSION, request.GetServiceRequestName()},
{TracingUtils::SMITHY_SERVICE_DIMENSION, this->GetServiceClientName()},
{TracingUtils::SMITHY_SYSTEM_DIMENSION, TracingUtils::SMITHY_METHOD_AWS_VALUE}},
smithy::components::tracing::SpanKind::CLIENT);
return TracingUtils::MakeCallWithTiming<ListTagsForResourceOutcome>(
[&]() -> ListTagsForResourceOutcome {
auto result =
MakeRequestDeserialize(&request, request.GetServiceRequestName(), Aws::Http::HttpMethod::HTTP_POST,
[&](Aws::Endpoint::AWSEndpoint& resolvedEndpoint) -> void { AWS_UNREFERENCED_PARAM(resolvedEndpoint); });
return result.IsSuccess() ? ListTagsForResourceOutcome(result.GetResultWithOwnership())
: ListTagsForResourceOutcome(std::move(result.GetError()));
},
TracingUtils::SMITHY_CLIENT_DURATION_METRIC, *meter,
{{TracingUtils::SMITHY_METHOD_DIMENSION, request.GetServiceRequestName()},
{TracingUtils::SMITHY_SERVICE_DIMENSION, this->GetServiceClientName()}});
auto result = InvokeServiceOperation(request, Aws::Http::HttpMethod::HTTP_POST);
return result.IsSuccess() ? ListTagsForResourceOutcome(result.GetResultWithOwnership())
: ListTagsForResourceOutcome(std::move(result.GetError()));
}

TagResourceOutcome BedrockDataAutomationRuntimeClient::TagResource(const TagResourceRequest& request) const {
AWS_OPERATION_GUARD(TagResource);
AWS_OPERATION_CHECK_PTR(m_endpointProvider, TagResource, CoreErrors, CoreErrors::ENDPOINT_RESOLUTION_FAILURE);
AWS_OPERATION_CHECK_PTR(m_clientConfiguration.telemetryProvider, TagResource, CoreErrors, CoreErrors::NOT_INITIALIZED);
auto tracer = m_clientConfiguration.telemetryProvider->getTracer(this->GetServiceClientName(), {});
auto meter = m_clientConfiguration.telemetryProvider->getMeter(this->GetServiceClientName(), {});
AWS_OPERATION_CHECK_PTR(meter, TagResource, CoreErrors, CoreErrors::NOT_INITIALIZED);
auto span = tracer->CreateSpan(Aws::String(this->GetServiceClientName()) + ".TagResource",
{{TracingUtils::SMITHY_METHOD_DIMENSION, request.GetServiceRequestName()},
{TracingUtils::SMITHY_SERVICE_DIMENSION, this->GetServiceClientName()},
{TracingUtils::SMITHY_SYSTEM_DIMENSION, TracingUtils::SMITHY_METHOD_AWS_VALUE}},
smithy::components::tracing::SpanKind::CLIENT);
return TracingUtils::MakeCallWithTiming<TagResourceOutcome>(
[&]() -> TagResourceOutcome {
auto result =
MakeRequestDeserialize(&request, request.GetServiceRequestName(), Aws::Http::HttpMethod::HTTP_POST,
[&](Aws::Endpoint::AWSEndpoint& resolvedEndpoint) -> void { AWS_UNREFERENCED_PARAM(resolvedEndpoint); });
return result.IsSuccess() ? TagResourceOutcome(result.GetResultWithOwnership()) : TagResourceOutcome(std::move(result.GetError()));
},
TracingUtils::SMITHY_CLIENT_DURATION_METRIC, *meter,
{{TracingUtils::SMITHY_METHOD_DIMENSION, request.GetServiceRequestName()},
{TracingUtils::SMITHY_SERVICE_DIMENSION, this->GetServiceClientName()}});
auto result = InvokeServiceOperation(request, Aws::Http::HttpMethod::HTTP_POST);
return result.IsSuccess() ? TagResourceOutcome(result.GetResultWithOwnership()) : TagResourceOutcome(std::move(result.GetError()));
}

UntagResourceOutcome BedrockDataAutomationRuntimeClient::UntagResource(const UntagResourceRequest& request) const {
AWS_OPERATION_GUARD(UntagResource);
AWS_OPERATION_CHECK_PTR(m_endpointProvider, UntagResource, CoreErrors, CoreErrors::ENDPOINT_RESOLUTION_FAILURE);
AWS_OPERATION_CHECK_PTR(m_clientConfiguration.telemetryProvider, UntagResource, CoreErrors, CoreErrors::NOT_INITIALIZED);
auto tracer = m_clientConfiguration.telemetryProvider->getTracer(this->GetServiceClientName(), {});
auto meter = m_clientConfiguration.telemetryProvider->getMeter(this->GetServiceClientName(), {});
AWS_OPERATION_CHECK_PTR(meter, UntagResource, CoreErrors, CoreErrors::NOT_INITIALIZED);
auto span = tracer->CreateSpan(Aws::String(this->GetServiceClientName()) + ".UntagResource",
{{TracingUtils::SMITHY_METHOD_DIMENSION, request.GetServiceRequestName()},
{TracingUtils::SMITHY_SERVICE_DIMENSION, this->GetServiceClientName()},
{TracingUtils::SMITHY_SYSTEM_DIMENSION, TracingUtils::SMITHY_METHOD_AWS_VALUE}},
smithy::components::tracing::SpanKind::CLIENT);
return TracingUtils::MakeCallWithTiming<UntagResourceOutcome>(
[&]() -> UntagResourceOutcome {
auto result =
MakeRequestDeserialize(&request, request.GetServiceRequestName(), Aws::Http::HttpMethod::HTTP_POST,
[&](Aws::Endpoint::AWSEndpoint& resolvedEndpoint) -> void { AWS_UNREFERENCED_PARAM(resolvedEndpoint); });
return result.IsSuccess() ? UntagResourceOutcome(result.GetResultWithOwnership())
: UntagResourceOutcome(std::move(result.GetError()));
},
TracingUtils::SMITHY_CLIENT_DURATION_METRIC, *meter,
{{TracingUtils::SMITHY_METHOD_DIMENSION, request.GetServiceRequestName()},
{TracingUtils::SMITHY_SERVICE_DIMENSION, this->GetServiceClientName()}});
auto result = InvokeServiceOperation(request, Aws::Http::HttpMethod::HTTP_POST);
return result.IsSuccess() ? UntagResourceOutcome(result.GetResultWithOwnership()) : UntagResourceOutcome(std::move(result.GetError()));
}
6 changes: 6 additions & 0 deletions ...bedrock-data-automation/include/aws/bedrock-data-automation/BedrockDataAutomationClient.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -859,6 +859,12 @@ class AWS_BEDROCKDATAAUTOMATION_API BedrockDataAutomationClient

private:
friend class Aws::Client::ClientWithAsyncTemplateMethods<BedrockDataAutomationClient>;

typedef Aws::Utils::Outcome<Aws::AmazonWebServiceResult<Aws::Utils::Json::JsonValue>, BedrockDataAutomationError> InvokeOperationOutcome;

InvokeOperationOutcome InvokeServiceOperation(const AmazonWebServiceRequest& request,
const std::function<void(Aws::Endpoint::AWSEndpoint&)>& resolveUri,
Aws::Http::HttpMethod httpMethod) const;
};

} // namespace BedrockDataAutomation
Expand Down
Loading
Loading