defense in depth fix for path traversal in transfer manager#3816
Merged
defense in depth fix for path traversal in transfer manager#3816
Conversation
kai-ion
approved these changes
May 5, 2026
ddf8091 to
d2c7f17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Related to Partial Path Traversal in aws-cpp-sdk-transfer and is a defense in depth fix for further scenarios.
A key like
/home/user/dl/safe/../../etc/passwdwritten to/home/user/dlwould trigger this scenario, and would be able to break out of the running directory and write in theory however in practice it is non-exploitable given that libcurl will compress the url by default resulting in a broken head object failing the transfer. additionally S3 no longer allows a object like this to be created sever side.Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.