Skip to content

Stop using the now deprecated std::is_trivial.#3820

Merged
sbiscigl merged 1 commit intomainfrom
pr/3819
May 7, 2026
Merged

Stop using the now deprecated std::is_trivial.#3820
sbiscigl merged 1 commit intomainfrom
pr/3819

Conversation

@sbiscigl
Copy link
Copy Markdown
Collaborator

@sbiscigl sbiscigl commented May 7, 2026

mergable version of #3819

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

std::is_trivial is deprecated in C++26. Using gcc 15 and C++26 yields
this warning:

/data/mwrep/res/mdw/SIOTF/internal/osp/aws_sdk/25-0-0-1/include/aws/core/utils/memory/AWSMemory.h: In function 'Aws::UniquePtr<T> Aws::MakeUnique(const char*, ArgTypes&& ...)':
/data/mwrep/res/mdw/SIOTF/internal/osp/aws_sdk/25-0-0-1/include/aws/core/utils/memory/AWSMemory.h:307:56: error: 'template<class _Tp> struct std::is_trivial' is deprecated: use 'is_trivially_default_constructible && is_triviall
y_copyable' instead [-Werror=deprecated-declarations]
  307 |         static_assert(!std::is_array<T>::value || std::is_trivial<T>::value,
      |                                                        ^~~~~~~~~~

So do as gcc suggests, and replace it by a combination of
is_trivially_default_constructible and is_trivially_copyable.
@sbiscigl sbiscigl marked this pull request as ready for review May 7, 2026 15:27
@sbiscigl sbiscigl merged commit 263055e into main May 7, 2026
5 of 7 checks passed
@sbiscigl sbiscigl deleted the pr/3819 branch May 7, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants