Fix S3 CRT async request lifetime - #3944
Open
FranciscoMaxwell wants to merge 1 commit into
Open
FranciscoMaxwell wants to merge 1 commit into
FranciscoMaxwell wants to merge 1 commit into
Conversation
Collaborator
|
looks good to me outside two things:
beyond those two things i am good to merge this barring anything that may turn up in CI |
sbiscigl
reviewed
Sep 25, 2026
| CopyObjectResponseReceivedHandler copyResponseHandler; | ||
| std::shared_ptr<const Aws::Client::AsyncCallerContext> asyncCallerContext; | ||
| const Aws::AmazonWebServiceRequest* originalRequest; | ||
| std::shared_ptr<const Aws::AmazonWebServiceRequest> originalRequest; |
Collaborator
There was a problem hiding this comment.
does this need to be a shared_ptr? since we are purely life time extending it why not use Aws::UniquePtr like we do for checksumConfig?
FranciscoMaxwell
force-pushed
the
fix-s3crt-request-lifetime
branch
from
September 25, 2026 18:37
f757fbb to
abf744c
Compare
Author
|
Thanks for the feedback. I have updated the PR accordingly.
Validated with: The updated signed commit is |
11 tasks
Collaborator
|
due to process reasons I created a PR with your commit on it, we will merge it from there |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #3881
Description of changes:
This updates the S3 CRT async callback state to keep the original service request alive until the CRT shutdown callback runs.
Previously, CrtRequestCallbackUserData stored originalRequest as a raw pointer to the request reference passed into CopyObjectAsync, GetObjectAsync, and PutObjectAsync. Those async methods can return before the CRT callbacks finish, leaving headers/body/progress/shutdown callbacks with a dangling pointer when they access GetContinueRequestHandler() or pass the typed request to the user response handler.
The callback data now owns a shared_ptr copy of the request. InitCommonCrtRequestOption receives and stores that shared_ptr, and the shutdown callbacks use the owned request when invoking the user handler.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
Testing:
git diff --checkcmake -S . -B build-s3crt -DBUILD_ONLY=s3-crt -DENABLE_TESTING=OFF -DAUTORUN_UNIT_TESTS=OFFcmake --build build-s3crt --config Release --target aws-cpp-sdk-s3-crt -- /mBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.