Changed GeneratedServiceMetadataProvider to lazily load elements. Updated unit tests based to reflect changes.#3686
Closed
awmcc90 wants to merge 1 commit into
Closed
Changed GeneratedServiceMetadataProvider to lazily load elements. Updated unit tests based to reflect changes.#3686awmcc90 wants to merge 1 commit into
awmcc90 wants to merge 1 commit into
Conversation
…ated unit tests based on generated code updates.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
GeneratedServiceMetadataProvidertakes a while to initialize. This was benchmarked and shown in this ticket. Lazily loading metadata significantly reduces the overhead required to initialize this class and reduces the time it takes to load substantially. This is important in the era of serverless infrastructure where cold start times need to be minimized.Resolves #3664
Modifications
ServiceMetadataProviderGeneratorServiceMetadataentries in the constructorServiceMetadatafactory method which accepts aStringvalue (same as before) and generates the associatedServiceMetadatawhen required.ServiceMetadataobjects are cached using the same map as before and this is checked prior to calling the factoryservice-metadata-provider.javato reflect newGeneratedServiceMetadataProviderstructureTesting
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License