Remove resolveClientEndpointProvider from AwsDefaultClientBuilder#7186
Open
S-Saranya1 wants to merge 2 commits into
Open
Conversation
This fallback method was triggering GeneratedServiceMetadataProvider initialization (~350ms) during every client creation because AttributeMap.build() eagerly resolves all lazy values including lazyOptionIfAbsent fallbacks. All generated clients have set CLIENT_ENDPOINT_PROVIDER themselves since SDK 2.27.16. Added null validation with clear error message for custom clients that don't set it
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
AwsDefaultClientBuilder.resolveClientEndpointProvider() was triggering GeneratedServiceMetadataProvider initialization (~350ms) during every client creation. Although registered via lazyOptionIfAbsent as a fallback for older clients, AttributeMap.build() eagerly resolves all lazy values — causing the fallback to execute even when the generated builder already set CLIENT_ENDPOINT_PROVIDER. All generated clients have set it themselves since 2024, making this fallback dead code with a significant performance cost.
Additionally, AwsClientEndpointProvider.build() is the method that calls ServiceMetadata.of() and triggers the expensive initialization. After our changes across PRs #7094, #7105, #7110, #7168, no code path in client creation calls it anymore. Deprecating it signals to not use and use resolveFromOverrides() + service EndpointProvider instead, and prevents accidental re-introduction of the performance issue.
Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License