Update for MediaGoblin >= 0.9.0 with multi-resolution video. - #2
Open
BenSturmfels wants to merge 1 commit into
Open
Update for MediaGoblin >= 0.9.0 with multi-resolution video.#2BenSturmfels wants to merge 1 commit into
BenSturmfels wants to merge 1 commit into
Conversation
Also fixes the double-forwardslash in URLs. A more robust approach would be to use `urllib.parse.urljoin`. This is a little bit of a lash-up, since the administrator could have defined custom resolutions in the configuration.
Author
|
Hi Andrew, I'm just tidying up and figured it might be good to include this small change in your canonical version of mediagoblin-embedcode if you're willing, so that others might find it, since they'll likely find your repo before my fork. If you'd prefer, we could also adopt this repo into the project repositories at https://git.sr.ht/~mediagoblin/. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This approach isn't perfect, since the administrator could have defined custom resolutions in the configuration, but this at least provides a minimal level of support for default configurations.
Also fixes the double-forwardslash in URLs. A more robust approach would be to use
urllib.parse.urljoin.