refactor(nostr): use Java Base64 for Blossom auth headers#616
Open
NicolaLS wants to merge 1 commit into
Open
Conversation
Replace `android.util.Base64` with `java.util.Base64` for Blossom auth headers. This facilitates easier testing of `Blossom.createUploadAuth` by removing the need for android instrumentation or roboelectric tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
android.util.Base64withjava.util.Base64for Blossom auth headers. This facilitates easier testing ofBlossom.createUploadAuthby removing the need for android instrumentation or roboelectric tests.The behavior is equivalent:
json.toByteArray(Charsets.UTF_8)uses toByteArray default parameter which is alreadyCharsets.UTF_8.android.util.Base64sNO_WRAPflag is the default in thejava.util.Base64Basic Encoder