Fix Go SDK Content-Type on GET requests

[robzolkos]

Summary

• stop setting Content-Type: application/json on bodyless Go SDK requests
• keep Accept: application/json on requests and keep Content-Type for JSON bodies
• add regression coverage for raw GETs and generated Search GETs

Why

Content-Type describes the request body. Bodyless GET requests use URL query parameters, and sending Content-Type: application/json causes /search.json?q=... to return unfiltered results.

Fixes #324.

Tests

• go test ./go/pkg/basecamp
• go test ./go/...

---

Summary by cubic

Stop sending Content-Type: application/json on bodyless GET requests in the Go SDK (go/pkg/basecamp) to fix unfiltered /search.json results (Fixes #324). Accept: application/json stays; Content-Type is only set when a JSON body exists and isn’t already set.

• Bug Fixes
  • Add requestHasBody and use it in the generated client and singleRequest so Content-Type is only set with a body; always set Accept: application/json.
  • Tests cover: GET without Content-Type, POST sets JSON Content-Type, POST preserves an existing Content-Type via an auth strategy and asserts it was empty before auth runs, and Search GET checks headers and q param.

^{Written for commit 767a8ff. Summary will update on new commits.}

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds safeguards to avoid sending a Content-Type header on bodyless GET requests, aligning request headers with HTTP semantics and preventing confusing/incorrect metadata.

Changes:

• Update client request building to only set Content-Type: application/json when a body is present.
• Introduce a requestHasBody helper used by the generated-client request path.
• Add tests covering GET (no Content-Type) and POST (JSON Content-Type) behavior, plus a higher-level search test.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
go/pkg/basecamp/search_test.go	Adds a regression test ensuring Search() GET requests don’t send Content-Type.
go/pkg/basecamp/client_test.go	Adds unit tests asserting correct header behavior for GET vs POST.
go/pkg/basecamp/client.go	Changes header-setting logic to be body-aware; adds requestHasBody helper.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[cubic-dev-ai]

1 issue found across 3 files

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[robzolkos]

Fixed — addressed the review feedback by adding method assertions, using http.StatusOK, and aligning body detection.

[robzolkos]

Fixed — added the GET method assertion identified by cubic.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.

[robzolkos]

Fixed — addressed the latest Copilot review feedback by preserving existing Content-Type values and avoiding t.Fatalf in httptest handler goroutines.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.