-
Notifications
You must be signed in to change notification settings - Fork 12
Uploads: replace a file in place, and say which file each version is #683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
245a4c3
Spec: replace an upload's file, and say which file each version is
jeremy cae9ed4
Go: CreateVersion, a real UploadVersion, and a reachable description …
jeremy dde4d17
All six SDKs: a 507 is a limit, not a retryable server error
jeremy 9290e67
Conformance: both uploads write paths, across all six runners
jeremy 63286d1
Docs: the counts, the two breaks, and the divergence that narrowed
jeremy c093f65
Reconcile with #679's repin, and finish the 507 it left half-classified
jeremy 15ed1a7
Address Codex review: keep listVersions typed in TS and Kotlin
jeremy 923470f
Address Codex round 2: export the new TS types, and Python does break
jeremy d540e59
Address Codex round 3: map 507 in Go's raw request path too
jeremy bb91729
Address Codex round 4: filtering on blob_changed drops the original file
jeremy e32020e
Say what `current` actually is, without weakening it
jeremy 3ec4db3
Address Codex round 5: the six READMEs are public error references too
jeremy 228b851
Account for CreateUploadVersion on the grouped client (#682)
jeremy 17ed903
Correct SPEC §2's retry.max distribution: 44 -> 45 at max 2
jeremy a72e79e
Reconcile the rest of the derived counts, by sweeping instead of patc…
jeremy 6dc3788
List all eight 507 operations, not the four this PR touched
jeremy 1797145
Sweep the whole tree for stale operation counts, not the named files
jeremy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.