Skip to content

Extract setup profiles helper#1590

Merged
codeforester merged 1 commit into
mainfrom
1570-profiles-helper
Jul 12, 2026
Merged

Extract setup profiles helper#1590
codeforester merged 1 commit into
mainfrom
1570-profiles-helper

Conversation

@codeforester

Copy link
Copy Markdown
Collaborator

Summary

  • add setup_profiles.sh for setup/check profile parsing and dispatch helpers
  • keep existing public setup_* names while setup_common.sh sources the profile helper and keeps shared orchestration
  • update setup-common ownership docs and source-guard coverage for the new helper

Refs #1570

Validation

  • /Users/rameshhp/.base.d/base/.venv/bin/python -m pytest tests/test_setup_common_ownership_docs.py tests/test_contract_hardening.py -q
  • BASE_BASH_LIBS_DIR=/Users/rameshhp/work/base-bash-libs/lib/bash bats cli/bash/commands/basectl/tests/setup-common.bats
  • bash -n cli/bash/commands/basectl/subcommands/setup_common.sh cli/bash/commands/basectl/subcommands/setup_linux_debian.sh cli/bash/commands/basectl/subcommands/setup_macos_homebrew.sh cli/bash/commands/basectl/subcommands/setup_venv.sh cli/bash/commands/basectl/subcommands/setup_profiles.sh
  • shellcheck -S error cli/bash/commands/basectl/subcommands/setup_common.sh cli/bash/commands/basectl/subcommands/setup_linux_debian.sh cli/bash/commands/basectl/subcommands/setup_macos_homebrew.sh cli/bash/commands/basectl/subcommands/setup_venv.sh cli/bash/commands/basectl/subcommands/setup_profiles.sh
  • /Users/rameshhp/.base.d/base/.venv/bin/python -m pylint --rcfile=.pylintrc tests/test_setup_common_ownership_docs.py
  • git diff --check
  • env BASE_BASH_LIBS_DIR=/Users/rameshhp/work/base-bash-libs/lib/bash BASE_CACHE_DIR=/private/tmp/base-1570-profiles-helper bin/basectl setup --profile dev --dry-run
  • env BASE_BASH_LIBS_DIR=/Users/rameshhp/work/base-bash-libs/lib/bash BASE_CACHE_DIR=/private/tmp/base-1570-profiles-helper bin/basectl check --ci
  • env -u BASE_HOME BASE_BASH_LIBS_DIR=/Users/rameshhp/work/base-bash-libs/lib/bash BASE_CACHE_DIR=/private/tmp/base-1570-profiles-helper-full ./bin/base-test

@codeforester codeforester requested a review from a team as a code owner July 12, 2026 18:19
@codeforester codeforester merged commit d166fca into main Jul 12, 2026
26 checks passed
@codeforester codeforester deleted the 1570-profiles-helper branch July 12, 2026 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant