fix(core): reject transcript timestamp ranges - #1271
Open
phernandez wants to merge 1 commit into
Open
Conversation
Signed-off-by: phernandez <paul@basicmachines.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Transcript time ranges such as
[24:33.098 - 24:41.260]still matched Basic Memory's bracketed observation syntax. This is the remaining range-shaped case from #1219/#1239 and causes one junk observation category per transcript line.Closes #1270.
What Changed
[10:30am - 11:30am].Implementation Details
The existing narrow clock grammar is factored into one reusable regex fragment and composed into an optional spaced-range form. It still accepts only
MM:SS/HH:MM:SS-shaped values with optional dot or comma fractional seconds; it does not broaden the exclusion to arbitrary numeric categories.Testing
Automated
uv run pytest -q --no-cov tests/markdown/test_observation_edge_cases.py: 13 passedjust fast-check: passed Ruff fix/check, formatting, andtytype checkinggit diff --check: passedManual
Risks / Follow-ups
The matcher intentionally requires whitespace around the hyphen. Other transcript range separators can be added from concrete reports without guessing at semantic category syntax.