Skip to content

Allows to provide Lipo tool location via custom toolchain.#336

Open
DmitriiTcimbal wants to merge 2 commits into
bazelbuild:mainfrom
DmitriiTcimbal:feat/dmitrii-t/universal-binary-rule-custom-lipo-location
Open

Allows to provide Lipo tool location via custom toolchain.#336
DmitriiTcimbal wants to merge 2 commits into
bazelbuild:mainfrom
DmitriiTcimbal:feat/dmitrii-t/universal-binary-rule-custom-lipo-location

Conversation

@DmitriiTcimbal

@DmitriiTcimbal DmitriiTcimbal commented Jun 19, 2024

Copy link
Copy Markdown

There might be cases when universal_binary rule has to be used in the absence of a local Xcode/CLT installation. This MR allows the location of the Lipo tool to be provided via the custom toolchain.

@google-cla

google-cla Bot commented Jun 19, 2024

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@keith

keith commented Jul 5, 2025

Copy link
Copy Markdown
Member

I don't think it's possible to use this rule without xcode installed since it relies on this?

"_xcode_config": attr.label(

@keith

keith commented Jul 17, 2025

Copy link
Copy Markdown
Member

I think im wrong about that and it must be a no-op for linux at the very least. at first i wasn't thinking we should merge this but i've since seen that grpc started using this rule, and if you want to avoid major xcode version dependence you need this, so i think we should probably move forward with it. can you rebase and sign the CLA?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants