Remove macOS support from default toolchain#743
Draft
keith wants to merge 1 commit into
Draft
Conversation
Since this toolchain moved out of bazel, and bazel directly depends on apple_support, there's no reason to have a separate toolchain supporting the same platform. On top of that the macOS support in this toolchain isn't fully hermetic, and would require a lot of copy pasting from the apple_support toolchain to get there, for seemingly no benefit.
dzbarsky
reviewed
Jun 11, 2026
| ) | ||
| if darwin: | ||
| overridden_tools["gcc"] = "cc_wrapper.sh" | ||
| overridden_tools["ar"] = _find_generic(repository_ctx, "libtool", "LIBTOOL", overridden_tools) |
Contributor
There was a problem hiding this comment.
@keith mind porting the ar/libtool flag thing to the better apple toolchain so we don't lose this fix?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this toolchain moved out of bazel, and bazel directly depends on
apple_support, there's no reason to have a separate toolchain supporting
the same platform. On top of that the macOS support in this toolchain
isn't fully hermetic, and would require a lot of copy pasting from the
apple_support toolchain to get there, for seemingly no benefit.