Skip to content

Fix coverage for crates with mixed sources #4079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
martingms wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −0
Open

Fix coverage for crates with mixed sources #4079

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions rust/private/rustc.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1303,6 +1303,15 @@ def construct_arguments(
# https://doc.rust-lang.org/rustc/instrument-coverage.html
rustc_flags.add("--codegen=instrument-coverage")

# Crates with generated sources are compiled from the output tree (see
# `transform_sources`), so the coverage mapping records their files
# with a bazel-out/... prefix. Bazel's lcov merger silently drops all
# coverage for such crates, so we remap the prefix away. Skipped when
# `remap_path_prefix` is None (rustdoc), since rustdoc only supports
# `--remap-path-prefix` behind `-Zunstable-options`.
if remap_path_prefix != None:
rustc_flags.add("--remap-path-prefix={}/=".format(ctx.bin_dir.path))

if toolchain._experimental_link_std_dylib:
rustc_flags.add("--codegen=prefer-dynamic")

Expand Down
Loading