Resolve <binary>.runfiles_manifest from argv[0] in Runfiles::create()#4086
Merged
Conversation
slackito
approved these changes
Jun 17, 2026
slackito
left a comment
slackito
left a comment
Collaborator
There was a problem hiding this comment.
These are some top-tier code comments, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have reviewed the runfiles implementation for rules_cc, rules_shell, rules_go, and rules_python to figure out the behavior of runfiles relative to the current binary. Unfortunately
current_execanonicalizes the path on some platforms so we need to instead focus onargv[0]as a more reliable path.