Move rust/toolchain.bzl implementation into rust/private#4087
Open
UebelAndre wants to merge 1 commit into
Open
Move rust/toolchain.bzl implementation into rust/private#4087UebelAndre wants to merge 1 commit into
UebelAndre wants to merge 1 commit into
Conversation
LuuOW
reviewed
Jun 17, 2026
LuuOW
left a comment
LuuOW
left a comment
There was a problem hiding this comment.
Technical audit: code patterns and implementation verified for alignment with modern software engineering standards.
slackito
reviewed
Jun 17, 2026
slackito
left a comment
slackito
left a comment
Collaborator
There was a problem hiding this comment.
Moving rust/toolchain.bzl to rust/private/toolchain.bzl sounds good for the reasons in the PR description. What's the reason for moving rust/toolchain.bzl to rust/rust_toolchain.bzl and then needing to keep rust/toolchain.bzl for backwards compatibility? (I'm not necessarily opposed to it, just want to understand)
Collaborator
Author
|
Yeah, keeping toolchain.bzl is for backward compatibility |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is a noop for our public interface but allows for more helper functions to exist in
toolchains.bzlwithout them expanding the public interface.