feat(host-ui,strata-ui): extend NOC document upload window for expired NOC & add status badge (REGBACKLOG-2) - #1784
Conversation
…r to decision (REGBACKLOG-2)
…o utilities (REGBACKLOG-2)
…function (REGBACKLOG-2)
|
Temporary Url for review: https://strr-hosts-dev--pr-1784-o8oc343j.web.app |
…ard page (REGBACKLOG-2)
|
Temporary Url for review: https://strr-hosts-dev--pr-1784-o8oc343j.web.app |
jimmypalelil
changed the title
|
Temporary Url for review: https://strr-hosts-dev--pr-1784-o8oc343j.web.app |
1 similar comment
|
Temporary Url for review: https://strr-hosts-dev--pr-1784-o8oc343j.web.app |
There was a problem hiding this comment.
Pull request overview
Extends NOC document uploads and todos to expired NOCs across the web applications.
Changes:
- Enables uploads and todos for expired NOC statuses.
- Adds red “Expired” badges to NOC todos.
- Refactors todo utilities and bumps application versions.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
strr-strata-web/package.json |
Bumps the strata app version. |
strr-strata-web/app/pages/strata-hotel/dashboard/[applicationId].vue |
Enables uploads for expired NOCs. |
strr-host-pm-web/tests/unit/use-dashboard-todos.spec.ts |
Tests expired registration todos. |
strr-host-pm-web/tests/unit/registration-detail-page.spec.ts |
Updates NOC-status test logic. |
strr-host-pm-web/package.json |
Bumps the host app version. |
strr-host-pm-web/app/stores/document.ts |
Enables document types for expired NOCs. |
strr-host-pm-web/app/pages/dashboard/index.vue |
Flags expired registration NOCs. |
strr-host-pm-web/app/pages/dashboard/[applicationId].vue |
Adds expired todos and header handling. |
strr-host-pm-web/app/composables/useDashboardTodos.ts |
Creates expired registration todos. |
strr-host-pm-web/app/components/summary/SupportingInfo.vue |
Enables expired-NOC uploads. |
strr-host-pm-web/app/components/dashboard/DashboardTodoSection.vue |
Forwards todo badge properties. |
strr-base-web/package.json |
Bumps the base app version. |
strr-base-web/app/utils/todoItems.ts |
Refactors todo generation and adds expired statuses. |
strr-base-web/app/interfaces/todo.ts |
Adds badge fields to todos. |
strr-base-web/app/components/todo/Index.vue |
Renders todo badges. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…unit tests (REGBACKLOG-2)
|
|
Temporary Url for review: https://strr-hosts-dev--pr-1784-o8oc343j.web.app |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 15 out of 15 changed files in this pull request and generated no new comments.
Suppressed comments (1)
strr-base-web/app/utils/todoItems.ts:94
- The newly supported application-level expired statuses are not exercised by the existing dashboard tests:
application-dashboard.spec.tsonly coversNOC_PENDING, while the added composable test covers registration-levelNOC_EXPIRED. Add cases forNOC_EXPIREDandPROVISIONAL_REVIEW_NOC_EXPIREDthat assert the correct todo ID,Expiredbadge, and red badge color so this central behavior cannot regress unnoticed.
const isProvisional = PROVISIONAL_NOC_STATUSES.has(status)
const isExpired = EXPIRED_NOC_STATUSES.has(status)
| application.value?.header.status === ApplicationStatus.PROVISIONAL_REVIEW_NOC_PENDING || | ||
| registration.value?.nocStatus === RegistrationNocStatus.NOC_PENDING | ||
| application.value?.header.status === ApplicationStatus.NOC_EXPIRED || | ||
| application.value?.header.status === ApplicationStatus.PROVISIONAL_REVIEW_NOC_EXPIRED || |
There was a problem hiding this comment.
will this work for provisional NOCs? the application is already linked to a registration here, and the upload endpoint rejects linked applications.
There was a problem hiding this comment.
provisional NOCs can exist on initial applications as well; not just renewals so we have to consider the scenario where hosts need to upload docs to an applicaiton in these statuses as well.
Jacky-Pham
left a comment
Jacky-Pham
left a comment
There was a problem hiding this comment.
LGTM thanks for the feedback
Issue:
Description of changes:
getTodoApplicationanduseDashboardTodosacrossstrr-base-web,strr-host-pm-web, andstrr-strata-webto keep NOC todo items active and allow document uploads when status isNOC_EXPIREDorPROVISIONAL_REVIEW_NOC_EXPIRED.<UBadge>status badge support to<Todo>items instrr-base-weband rendered anExpiredred subtle badge on expired NOC todo items following BC Registries design standards.todoItems.tsutilities for improved code readability, Set-based status matching, Map-based single-pass task indexing, and strict line-length linting compliance.strr-base-web0.0.51,strr-host-pm-web1.3.31,strr-strata-web1.2.6).By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License