34469 - Fix BaseAddress valid event stuck false when postal code never blurred - #317
Merged
Merged
Conversation
2 tasks
Collaborator
Author
|
Note to self: after this is merged and published to npm, the consumer repos still need a version bump to pick it up — business-edit-ui pins |
Collaborator
Author
i copied the code change to business edit ui, and ran it locally against firm draft. Working as expected, able to press save and progress the UI. Denote by "Undo" change in ui.
|
mruff-aeq
requested review from
kialj876 and
meawong
and removed request for
kialj876
August 10, 2026 15:18
kialj876
approved these changes
Aug 10, 2026
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: bcgov/entity#34469
Description:
BaseAddress
validemit was gated on postal-code blur, so clearing only address line 2 left the parent stuck invalid and Done silently no-oped; emit now uses the Vuelidate postal state instead.