chore: upgrade packageManager to pnpm@11.9.0 - #875
Open
panish16 wants to merge 8 commits into
Open
Conversation
panish16
requested review from
davemck513,
mengdong19,
ozamani9gh and
stevenc987
as code owners
June 25, 2026 17:48
…asInjectionContext not available in vue-demi v2 mode)
pnpm v11 stopped reading package.json's "pnpm" key, silently dropping the sbc-common-components patch and build-script approvals and causing a lockfile mismatch. Move both to pnpm-workspace.yaml and regenerate the lockfile (which also fixes a stale pinia resolution: package.json already pinned ~2.0.35 for Vue 2 compatibility, but the committed lockfile still resolved 2.3.1).
…mpat
The production linting-pnpm (24, 9) job still runs pnpm 9, which
requires a non-missing "packages" field in any pnpm-workspace.yaml it
finds ("ERROR packages field missing or empty"), even though this file
exists purely for pnpm 11's allowBuilds/patchedDependencies settings.
Declare packages: [] explicitly so both pnpm versions handle the file.
The shared bcregistry-sre/frontend-ci.yaml workflow defaults pnpm_version to "9" when unset, and pnpm/action-setup doesn't defer to packageManager for that bare default. Pin pnpm_version to 11.9.0 explicitly, matching packageManager, as a stopgap until bcgov/bcregistry-sre#369 lands.
version: latest-11 is a floating tag; it just moved to 11.12.0 and hit a pnpm/action-setup self-install bug. Pinned to 11.9.0 to match packageManager. Also added --ignore-scripts + explicit nuxt prepare, since plain pnpm install fails under pnpm 11 without approved builds.
namerequest is a Vue2/Vite app, not Nuxt - 'nuxt' command isn't available. Matching the shared frontend-ci.yaml's own defensive pattern (2>/dev/null || true, continue-on-error) instead of assuming every app is Nuxt-based.
Contributor
Author
|
/gcbrun |
2 similar comments
Contributor
Author
|
/gcbrun |
Collaborator
|
/gcbrun |
Collaborator
|
Temporary Url for review: https://namerequest-dev--pr-875-b9nqmlwa.web.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets
packageManagertopnpm@11.9.0inapp/package.jsonas part of the pnpm v11 upgrade (ticket #33875).The Cloud Build CI trigger has already been updated to use
pnpm@11.9.0.