Install workflow deps from pyproject.toml dependency groups#356
Closed
gwdio wants to merge 3 commits into
Closed
Conversation
Replace the hardcoded requirements.txt install with --group reads from briefcase-template's pyproject.toml, unblocking the migration in beeware/briefcase-template#236.
pip requires dependency group paths to point to the pyproject.toml file directly, not just the directory containing it.
phildini
approved these changes
May 19, 2026
Member
phildini
left a comment
phildini
left a comment
There was a problem hiding this comment.
@freakboy3742 I have reviewed this and think it's good, and have considered the implications, but I think it needs at least a glance from you because it affects the full downstream pipelines.
| - name: Install Dependencies | ||
| # must install before Briefcase below since requirements.txt contains an entry for Briefcase | ||
| run: python -m pip install -Ur ./briefcase-template/requirements.txt | ||
| run: python -m pip install --group './briefcase-template/pyproject.toml:test' --group './briefcase-template/pyproject.toml:dev' |
Member
There was a problem hiding this comment.
TIL about the filename:group syntax for --group.
I think we might need to revisit the groupings in briefcase-template to make them a little more focussed. I think the set we need is:
- pre-commit (to run the pre-commit step on briefcase-template)
- tox (to run the unit-test step on briefcase-template)
- briefcase (as an explicit target for just briefcase, which is what app-create and app-build should need)
- test (the things needed to run the actual test suite - pytest, black, etc, including a link to the briefcase target)
- dev (for local development, linking essentially all of the above into a single target)
Contributor
Author
|
After the dependency group refactor in beeware/briefcase-template#262, this branch's changes no longer reflect the target schema. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the hardcoded requirements.txt install with --group reads from briefcase-template's pyproject.toml, unblocking the migration in beeware/briefcase-template#236.
Update
app-create-verify.ymlto install briefcase-template's workflow dependencies via PEP 735 dependency groups (--group) instead ofrequirements.txt. Adds a pip upgrade step since--grouprequires pip ≥ 25.1.Unblocks beeware/briefcase-template#236, which migrates that repo to
pyproject.toml. The workflow currently hardcodespip install -Ur ./briefcase-template/requirements.txt, so deleting the file in the consumer repo would break this workflow for all consumers. Once this lands, the temporaryrequirements.txtstub in briefcase-template can be removed.Fixes #355
Refs beeware/briefcase-template#236
PR Checklist:
Assisted-by: Claude Opus 4.7