Skip to content

Take the bootstrap sweep off pull requests #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sscarduzio wants to merge 2 commits into from
Closed

Take the bootstrap sweep off pull requests #127

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f388b4
Take the bootstrap sweep off pull requests
sscarduzio Sep 10, 2026
c5a9431
Also cancel a superseded pull-request run
sscarduzio Sep 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions .github/workflows/all-e2e-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,14 @@ on:
pull_request:
types: [opened, synchronize, reopened]

# A second push to the same pull request makes the first run's result worthless, and this suite

@coutoPL coutoPL Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment violates @docs/dev/style-code.md

Please check other comments added/changed in the PR.

# holds runners for hours. Cancel it. Only for pull requests: on master, the nightly and a manual
# dispatch the group is the run id, which is unique, so those runs neither cancel nor queue behind
# each other. Grouping them by ref instead would park a nightly behind a master push for hours.
concurrency:
group: ${{ github.workflow }}-${{ github.event_name == 'pull_request' && github.ref || github.run_id }}
cancel-in-progress: ${{ github.event_name == 'pull_request' }}

env:
APPLY_RESOURCE_LIMITS: "auto"

Expand Down Expand Up @@ -99,11 +107,13 @@ jobs:
# Bootstrap uses released images (no --mode), as it did before.
master-bootstrap-tests:
name: "🚀 Bootstrap Tests"
# Not on a pull request. The matrix is 34 released versions x 2 envs, and every one of them
# tests plugins that are already out, so nothing a pull request changes can change the result.
# The nightly and a push to master still run it, because the released set moves there.
if: >
github.event_name == 'schedule' ||
github.event_name == 'workflow_dispatch' ||
(github.event_name == 'push' && github.ref == 'refs/heads/master') ||
(github.event_name == 'pull_request' && github.base_ref == 'master' && github.event.pull_request.head.repo.fork == false)
(github.event_name == 'push' && github.ref == 'refs/heads/master')
Comment thread
coutoPL marked this conversation as resolved.
needs: prod-e2e-tests
runs-on: ubuntu-latest
strategy:
Expand Down
Loading