Skip to content

Reconcile the readonlyrest_kbn in-repo Cypress copy into this suite #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coutoPL merged 5 commits into from
Sep 14, 2026
Merged

Reconcile the readonlyrest_kbn in-repo Cypress copy into this suite #133

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cdcb39f
Kibana-content-overwrite covers the in-app Rules -> Connectors route
sscarduzio Sep 12, 2026
cdddd11
Both skipped tests say why they are skipped and what lifts the skip
sscarduzio Sep 12, 2026
693b5c4
Kibana-content-overwrite walks each page once
sscarduzio Sep 13, 2026
781ee57
The two skip comments say only what lifts the skip
sscarduzio Sep 13, 2026
587df40
Merge remote-tracking branch 'origin/master' into reconcile-in-repo-c…
sscarduzio Sep 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion e2e-tests/cypress/e2e/ror-config.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { Settings } from '../support/page-objects/Settings';
import { Editor } from '../support/page-objects/Editor';
import { rorApiInternalKbnClient } from '../support/helpers/RorApiInternalKbnClient';

// TODO: Uncomment when functionality enabled
// It will be unskipped when https://github.com/beshu-tech/readonlyrest-e2e-tests/pull/116 is merged.

@10hexdev 10hexdev Bot Sep 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ror-config.cy.ts is deleted, not unskipped, by #116.

$ gh api repos/beshu-tech/readonlyrest-e2e-tests/pulls/116/files
  e2e-tests/cypress/e2e/ror-config.cy.ts | removed

The replacement spec #116 adds, Readonlyrest-settings.cy.ts, has seven it() blocks (disable multitenancy, index based session, custom CSS, custom JS, custom middleware, whitelisted Urls, tenancy) — none is should save ReadonlyREST Kibana config to the index, and none asserts Login.verifyLoginPageTitle('Loaded from index!') after RorMenu.pressLogoutButton().

So "It will be unskipped when … #116 is merged" names the wrong outcome: the file is removed, and its one save-to-index test has no replacement in #116.

Fix the comment to state what #116 does (deletes the file and migrates the settings coverage to Readonlyrest-settings.cy.ts without the save→logout→login-title assertion), or confirm with the #116 author that an equivalent test lands there before this merges.

describe.skip('Ror config', () => {
beforeEach(() => {
Login.initialization();
Expand Down
Loading