Conversation
Kibana 9.5.4 no longer loads the spaces.chunk bundle on a tenancy
switch, so the intercept never fires and cy.wait('@spacesPlugin')
times out. Mirrors the fix already applied in readonlyrest_kbn's
automatic-tests copy (PR #1043).
This comment was marked as resolved.
This comment was marked as resolved.
Collaborator
Author
|
Consolidating into a single PR against master (RORDEV-2229) — closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is broken
changeTenancyAndAwaitSpacesintercepts*/bundles/plugin/spaces/1.0.0/spaces.chunk*and waits forit on every Kibana version
>= 9.4.0. On Kibana 9.5.4 that bundle no longer loads on a tenancyswitch, so the intercept never fires and
cy.wait('@spacesPlugin')times out after 10s.This fails the sanity check ro kibana access and sanity check ro_strict kibana access specs on
every e2e run against ES/KBN 9.4.x and 9.5.4 since readonlyrest_kbn added 9.4.7/9.5.4 support
(RORDEV-2228/2230, readonlyrest_kbn#1043).
The fix
Cap the wait at Kibana
<= 9.5.3. This mirrors the fix already applied in readonlyrest_kbn's localautomatic-tests/copy of this same file (readonlyrest_kbn#1043) — that fix never made it into thisrepo, which is the actual source cloned by CI (
scripts/e2eTestsLib.shin readonlyrest_kbn pointshere), so every run kept hitting the unfixed code.
Follow-up
Same fix needs to land on
mastertoo, since a manual/dispatch run with no matching branch fallsback to
developthenmaster— I'll open a companion PR there.